[MIRROR] General maintainence for HPLC #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request
Moves around code for portable chem mixer & chem heater. No functional
changes, As for the HPLC
**1. Qol**
- Adds examines & screentips for
1) Screwdriver, crowbar & wrench acts
2) Inserting & replacing input/output beakers
3) Alt click ejecting input/output beakers
- Balloon alerts replaces chat messages to reduce spam.
- HPLC will now display the status of each reagent if it can be purified
or not before starting the refining process thus saving you the headache
of pressing the start button only to waste power & time & get no work
done
**2. Code Improvements**
- Moved screwdriver, wrench & crowbar acts out of `attackby()` into
their respective tool act PROCS
- Merged procs `calculate_largest_mass()` & ` calculate_smallest_mass()`
procs into a single proc `calculate_mass()` with a boolean var to decide
if we want the smallest or largest mass reagent
- Computes estimated time only when UI changes & not every ui update
**3. Fixes**
- HPLC won't accept hologram or abstract items
- HPLC now displays off icon state & pauses processing when the machine
is either opened, powered off, unanchored or broken
- HPLC will ignore reagents that are either already at max purity or are
inverse thus lowering eta & work done to purify your remaining reagents
**4. Refactor**
- Converted UI to typescript, moved vars such as `in_range` & `color` to
the client side to reduce data sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
https://api.github.com/repos/tgstation/tgstation/pulls/81613About The Pull Request
Moves around code for portable chem mixer & chem heater. No functional changes, As for the HPLC
1. Qol
2. Code Improvements
attackby()into their respective tool act PROCScalculate_largest_mass()&calculate_smallest_mass()procs into a single proccalculate_mass()with a boolean var to decide if we want the smallest or largest mass reagent3. Fixes
4. Refactor
in_range&colorto the client side to reduce data sent.Changelog
🆑
qol: adds examines & screentips for HPLC
qol: HPLC will now display the status of each reagent if it can be purified or not before starting the refining process.
fix: HPLC won't accept hologram items.
fix: HPLC uses the correct off icon state & pauses processing when opened, powered off, unanchored or broken
fix: HPLC will ignore reagents that are either already at max purity or are inverse thus lowering eta & work done to purify your remaining reagents
code: merged procs to reduce code size. auto Doc procs for HPLC
refactor: converted UI to typescript.
/:cl: