[MIRROR] Fixes Hatsune Migo Spawning Comments and Code #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
https://api.github.com/repos/tgstation/tgstation/pulls/81856About The Pull Request
The
prob()was not lining up with the comment,prob(0.04)is NOT 1/20 odds. it's also wack to have 1/20 odds for something meant to be super duper cool and rare (lest people get sick of the joke), so I balanced it to be aprob(0.1)odds as well (1/1000 i think).i also don't like how non-special the mi-go replacement was and detested the fact that the
descwould duplicate if an admin spawned in a mi-go twice (mentioning the blue hair twice), so let's make it a tad bit more sane by actually replacing it with the type introduced in that PR and checking against that type.Why It's Good For The Game
people would likely try to fix the way this worked in the future to match the comment and that's icky imo. let's rebalance it to be more sane and also clean up the code
Changelog
the odds of players having seen this sprite in game were already really rather low so let's not bother them with the tantalizing unknown