[MIRROR] Removing a job now removes its positions #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request I made the error of using the ``JOB_NEW_PLAYER_JOINABLE`` flag to prevent people from joining as AI, unaware that it only prevents latejoining as said job (despite ``total_positions`` also a var and ``JOB_HIDE_WHEN_EMPTY`` being a flag that you can change, making this whole flag pointless). ## Why It's Good For The Game Closes tgstation/tgstation#82014 ## Changelog :cl: fix: Human AI now closes regular AI job positions. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
https://api.github.com/repos/tgstation/tgstation/pulls/82015About The Pull Request
I made the error of using the
JOB_NEW_PLAYER_JOINABLEflag to prevent people from joining as AI, unaware that it only prevents latejoining as said job (despitetotal_positionsalso a var andJOB_HIDE_WHEN_EMPTYbeing a flag that you can change, making this whole flag pointless).Why It's Good For The Game
Closes tgstation/tgstation#82014
Changelog
🆑
fix: Human AI now closes regular AI job positions.
/:cl: