[MIRROR] [NO GBP] The deathmatch modifiers modal menu can actually be opened now. #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
https://api.github.com/repos/tgstation/tgstation/pulls/82041About The Pull Request
I've fucked up the logic, so it requires the user to be both the host and an admin to open it, which was the case when I tested it locally. This PR fixes that and other issues (and undumbs some of the code). The spinning screen modifier has also been scrapped for being downright awful and breaking my screen.
Why It's Good For The Game
Fixing stuff I've thankfully noticed early.
Changelog
🆑
fix: The deathmatch modifiers modal menu can actually be opened now. Also fixed a bunch of issues it had.
/:cl: