Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [No GBP] Vending examine message now properly shows the name of the vending refill required. #2988

Closed
wants to merge 1 commit into from

Conversation

NaakaKo
Copy link
Collaborator

@NaakaKo NaakaKo commented Mar 21, 2024

Original PR: https://api.github.com/repos/tgstation/tgstation/pulls/82101

About The Pull Request

Vending refills were piping in the typepath of the refill as opposed to the name since their examine was referencing a type path. This instead pulls the machine_name and name to form the correct string on examine to confirm that the value is accurate.
image

Why It's Good For The Game

Fixes #82095. That should probably not be shown in-game as is and now actually showcases the correct message on examine.

Changelog

🆑
fix: Vending machines now show the correct vending refill name when examine and not full.
/:cl:

@NaakaKo NaakaKo added the Upstream PR Merged Used by the mirror bot. label Mar 21, 2024
@CliffracerX CliffracerX closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream PR Merged Used by the mirror bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants