[MIRROR] Fixes envelope & reagent holder interaction #2994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request - Fixes #82122 This is a 2 part fix. - Reagent holders (cup & syringe the only cases i can find) will update the target appearance only when their action succeeds. This way they don't cause items like envelops to update after every interaction. - Envelope returns the stamp overlay in the return value of `update_overlays()` rather than calling `add_overlay()` so their overlays don't add up but rather get removed & replaced correctly. ## Changelog :cl: fix: reagent containers like cup & syringe only update target appearance if action was successful. fix: envelops don't stack overlays when interacting with cup & syringes. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
https://api.github.com/repos/tgstation/tgstation/pulls/82127About The Pull Request
This is a 2 part fix.
update_overlays()rather than callingadd_overlay()so their overlays don't add up but rather get removed & replaced correctly.Changelog
🆑
fix: reagent containers like cup & syringe only update target appearance if action was successful.
fix: envelops don't stack overlays when interacting with cup & syringes.
/:cl: