Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes music importing newlining #3013

Closed
wants to merge 2 commits into from
Closed

Conversation

NaakaKo
Copy link
Collaborator

@NaakaKo NaakaKo commented Mar 23, 2024

Original PR: https://api.github.com/repos/tgstation/tgstation/pulls/82152

About The Pull Request

Makes the instrument song importing tgui input text use multiline which means BPM is now on its own line instead of taking the first line of the song with it, getting it cut from the import.

Why It's Good For The Game

Closes tgstation/tgstation#82148

Changelog

🆑
fix: Importing songs into instruments no longer cuts the first line of the song.
/:cl:

JohnFulpWillard and others added 2 commits March 23, 2024 03:14
## About The Pull Request

Makes the instrument song importing tgui input text use multiline which
means BPM is now on its own line instead of taking the first line of the
song with it, getting it cut from the import.

## Why It's Good For The Game

Closes tgstation/tgstation#82148

## Changelog

:cl:
fix: Importing songs into instruments no longer cuts the first line of
the song.
/:cl:
@NaakaKo NaakaKo added the Upstream PR Merged Used by the mirror bot. label Mar 23, 2024
@CliffracerX CliffracerX closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream PR Merged Used by the mirror bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Musical instruments ignore the first line of notes when importing a song
3 participants