-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): bump react-redux package #2879
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Code Climate has analyzed commit 7026d11 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for wallet-defichain ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Missing Translations ReportThe following translations are missing for this pull request. {
"missingLanguageItems": {
"zh-Hans": {
"missingCount": 0,
"labels": {},
"totalCount": 1154,
"allLabels": "{}"
},
"zh-Hant": {
"missingCount": 0,
"labels": {},
"totalCount": 1154,
"allLabels": "{}"
},
"fr": {
"missingCount": 0,
"labels": {},
"totalCount": 1154,
"allLabels": "{}"
},
"es": {
"missingCount": 0,
"labels": {},
"totalCount": 1154,
"allLabels": "{}"
},
"it": {
"missingCount": 0,
"labels": {},
"totalCount": 1154,
"allLabels": "{}"
}
},
"totalMissingCount": 0
} |
✅ Deploy Preview for mobile-wallet-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #2879 +/- ##
==========================================
+ Coverage 81.23% 85.22% +3.99%
==========================================
Files 365 366 +1
Lines 8197 8198 +1
Branches 2101 2101
==========================================
+ Hits 6659 6987 +328
+ Misses 1512 1201 -311
+ Partials 26 10 -16
Continue to review full report at Codecov.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ FailuresThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
To add on React@18 update, we update react based on Expo support (and react-native in a way). |
Build preview for DeFiChain Wallet is ready! Built with commit b3d9538 https://expo.io/@defichain/wallet?release-channel=pr-preview-2879 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also remove @types/react-redux
as it's already included on the main package
What kind of PR is this?:
/kind chore
What this PR does / why we need it:
Upgrade to react-redux v8
React redux v8 upgrade key points:
Goal of react-redux v8 is to be compatible with React 18 (LW is currently using react v17.0.2)
References and other related discussions/announcements:
The only issue found on this upgrade is the infinite loop on the Feature Provider because of max retries which is fixed by using
useEffect
hookWhich issue(s) does this PR fixes?:
Fixes #2835
Additional comments?:
Developer Checklist: