Linter

Also call root.allocateNew() in GetInfoReader
Bit-Quill · Feb 17, 2024 · f540c72 · f540c72
1 parent 47caa0e
commit f540c72
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/...light-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/GetInfoMetadataReader.java b/...light-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/GetInfoMetadataReader.java
@@ -143,6 +143,7 @@ public boolean loadNextBatch() throws IOException {
       hasInMemoryDataBeenWritten = true;
       int dstIndex = 0;
       try (VectorSchemaRoot root = VectorSchemaRoot.create(readSchema(), allocator)) {
+        root.allocateNew();
         this.infoCodes = (UInt4Vector) root.getVector(0);
 
         if (requestedCodes.contains(AdbcInfoCode.DRIVER_NAME.getValue())) {
@@ -184,6 +185,7 @@ protected Schema readSchema() {
   @Override
   protected void processRootFromStream(VectorSchemaRoot root) {
     try (VectorSchemaRoot tmpRoot = VectorSchemaRoot.create(readSchema(), allocator)) {
+      root.allocateNew();
       this.infoCodes = (UInt4Vector) tmpRoot.getVector(0);
       this.infoValues = (DenseUnionVector) tmpRoot.getVector(1);
       this.stringValues = this.infoValues.getVarCharVector((byte) 0);

diff --git a/...t-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/GetObjectsMetadataReaders.java b/...t-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/GetObjectsMetadataReaders.java
@@ -203,7 +203,7 @@ protected VectorSchemaRoot getAggregateRoot() {
   }
 
   private static class GetCatalogsMetadataReader extends GetObjectMetadataReader {
-    private final @Nullable  Pattern catalogPattern;
+    private final @Nullable Pattern catalogPattern;
 
     protected GetCatalogsMetadataReader(
         BufferAllocator allocator,
@@ -351,7 +351,7 @@ private static class TableDefinition {
 
     private final String catalogPattern;
     private final String dbSchemaPattern;
-    private final @Nullable  Pattern compiledColumnNamePattern;
+    private final @Nullable Pattern compiledColumnNamePattern;
     private final boolean shouldGetColumns;
     private final Map<String, Map<String, Map<String, TableDefinition>>> tablePathToColumnsMap =
         new LinkedHashMap<>();
@@ -490,11 +490,15 @@ protected void finish() throws AdbcException, IOException {
           for (Object schemaStructObj : sourceSchemaStructList.getObject(i)) {
             final Map<String, Object> schemaStructAsMap = (Map<String, Object>) schemaStructObj;
             if (schemaStructAsMap == null) {
-              throw new IllegalStateException(String.format("Error in catalog %s: Null schema encountered when schemas were requested.", catalog));
+              throw new IllegalStateException(
+                  String.format(
+                      "Error in catalog %s: Null schema encountered when schemas were requested.",
+                      catalog));
             }
             Object schemaNameObj = schemaStructAsMap.get("db_schema_name");
             if (schemaNameObj == null) {
-              throw new IllegalStateException(String.format("Error in catalog %s: Schema with no name encountered.", catalog));
+              throw new IllegalStateException(
+                  String.format("Error in catalog %s: Schema with no name encountered.", catalog));
             }
             String schemaName = schemaNameObj.toString();