Skip to content

Commit

Permalink
Add a test-only dependency on logback to memory-core
Browse files Browse the repository at this point in the history
Memory-core tests utilize logback.
Note that this can't be added to the source module-info.java
without adding an unnecessary dependency. It also can't be
added to the test module-info.java without breaking the main
module since the tests use the same packages.
  • Loading branch information
jduo committed Jan 4, 2024
1 parent 1b2a35e commit d21b8b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion java/memory/memory-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration combine.self="override">
<argLine>--add-opens=java.base/java.lang.reflect=org.apache.arrow.memory.core --add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED</argLine>
<argLine>--add-reads=org.apache.arrow.memory.core=ch.qos.logback.classic --add-opens=java.base/java.lang.reflect=org.apache.arrow.memory.core --add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED</argLine>
<excludes>
<!-- Test is only useful when NOT running with add-opens -->
<exclude>**/TestOpens.java</exclude>
Expand Down

0 comments on commit d21b8b3

Please sign in to comment.