-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAC-45] Initial Version of FlightSQL Readme #10
Conversation
* fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests
* code uploading * fix cppcheck failure (#1) * fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests * verify signer works fine * fix singer could not find the installer package * change signed installer name * fix linux package wrong name issue * restore signer flag * add .gitignore * remove unneeded files * remove unneeded files * address comments * add version to installer name * remove not needed file
…mation improvement (#4) * fix occasional test failure * document update * add check for credentials leak
* pass driver info to Timestream using user agent * add log for user agent setting
Signed-off-by: forestmvey <[email protected]>
…ODBC driver seed disable integration tests from running. The win-build.yml file is copied from Amazon Timestream ODBC driver code.
Note that rest of lint errors are not solved yet.
* integration tests are disabled. * allow build scripts to be run through `chmod`.
* Updated workflows to accommodate this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have some minor comments
cpp/src/flightsql_odbc/amazon-timestream-odbc-driver/flightsql-readme.md
Outdated
Show resolved
Hide resolved
cpp/src/flightsql_odbc/amazon-timestream-odbc-driver/flightsql-readme.md
Outdated
Show resolved
Hide resolved
PR LGTM. Since we have a rebase-and-merge strategy here, please squash the two commits since they are for the same change. |
cpp/src/flightsql_odbc/amazon-timestream-odbc-driver/flightsql-readme.md
Outdated
Show resolved
Hide resolved
56f1af0
to
3d7217d
Compare
30b1456
to
65f181f
Compare
Ubuntu 20.04 Debug Build Test Results Check
|
MacOS Big Sur 11 Debug Build Code Coverage Unit and Integration Test Result
|
65f181f
to
6215306
Compare
Rationale for this change
Non existent FlightSQL readme file
What changes are included in this PR?
The initial version of FlightSQL readme file
Are these changes tested?
N/A
Are there any user-facing changes?
N/A