Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jedis and Lettuce benchmarks #1

Closed
wants to merge 34 commits into from
Closed

Add Jedis and Lettuce benchmarks #1

wants to merge 34 commits into from

Commits on Oct 3, 2023

  1. Add Jedis and Lettuce benchmarks

    @jonathanl-bq @acarbonetto
    jonathanl-bq authored and acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    06574ea View commit details
    Browse the repository at this point in the history

  2. Start ignoring .gradle files

    @jonathanl-bq @acarbonetto
    jonathanl-bq authored and acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    5990767 View commit details
    Browse the repository at this point in the history

  3. Update gitignore and remove generated files from git 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    6ae93f5 View commit details
    Browse the repository at this point in the history

  4. Update gitignore and remove generated files from git 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    8203c4d View commit details
    Browse the repository at this point in the history

  5. Update gitignore and remove generated files from git 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    e517744 View commit details
    Browse the repository at this point in the history

  6. Add benchmarks for GET non-existing

    @jonathanl-bq @acarbonetto
    jonathanl-bq authored and acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    2a11e9a View commit details
    Browse the repository at this point in the history

  7. Revert "Update gitignore and remove generated files from git" 

    This reverts commit d9b26a6.
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    cbb0dcb View commit details
    Browse the repository at this point in the history

  8. fix redis-rs submodules 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    5f51a5b View commit details
    Browse the repository at this point in the history

  9. Randomize commands in Java benchmarks

    @jonathanl-bq @acarbonetto
    jonathanl-bq authored and acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    52df672 View commit details
    Browse the repository at this point in the history

  10. rename chooseAction to randomAction

    @jonathanl-bq @acarbonetto
    jonathanl-bq authored and acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    84f0efc View commit details
    Browse the repository at this point in the history

  11. Add a Java benchmarking app (#7) 

    * Add a java app to run benchmarks

---------

Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    1983974 View commit details
    Browse the repository at this point in the history

  12. Add Readme and update install_and_test script to runJava 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    6c1fb45 View commit details
    Browse the repository at this point in the history

  13. Add Readme and update install_and_test script to runJava 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    46d0cf6 View commit details
    Browse the repository at this point in the history

  14. Combine java pipeline and java benchmarks (#8) 

    * Merge Pull Request #5 - Add java pipeline.

Also changed:
* Merged two projects.
* Updated CI.
* Fixed tests and updated `junit` version.
* Spotless.
* Add new gradle tasks.

Signed-off-by: Yury-Fridlyand <[email protected]>
    @Yury-Fridlyand @acarbonetto
    Yury-Fridlyand authored and acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d526f96 View commit details
    Browse the repository at this point in the history

  15. Add sync and async clients both to tests. (#12) 

    * Add sync and async clients both to tests.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Minor fixes.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
    @Yury-Fridlyand @acarbonetto
    Yury-Fridlyand authored and acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    436da8f View commit details
    Browse the repository at this point in the history

  16. Move duplicated logic in benchmark JS scripts to a single file, and c… 

    …onvert to TypeScript. (valkey-io#456)

removed duplicated logic and refactored to typescript

Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    016f5f6 View commit details
    Browse the repository at this point in the history

  17. Add dataSize option to java benchmark. (#11) 

    * Add Jedis and Lettuce benchmarks

* Start ignoring .gradle files

* Update gitignore and remove generated files from git

Signed-off-by: acarbonetto <[email protected]>

* Update gitignore and remove generated files from git

Signed-off-by: acarbonetto <[email protected]>

* Update gitignore and remove generated files from git

Signed-off-by: acarbonetto <[email protected]>

* Add benchmarks for GET non-existing

* Revert "Update gitignore and remove generated files from git"

This reverts commit d9b26a6.

* fix redis-rs submodules

Signed-off-by: acarbonetto <[email protected]>

* Randomize commands in Java benchmarks

* rename chooseAction to randomAction

* Add a Java benchmarking app (#7)

* Add a java app to run benchmarks

---------

Signed-off-by: acarbonetto <[email protected]>

* Add Readme and update install_and_test script to runJava

Signed-off-by: acarbonetto <[email protected]>

* Add Readme and update install_and_test script to runJava

Signed-off-by: acarbonetto <[email protected]>

* Combine java pipeline and java benchmarks (#8)

* Merge Pull Request #5 - Add java pipeline.

Also changed:
* Merged two projects.
* Updated CI.
* Fixed tests and updated `junit` version.
* Spotless.
* Add new gradle tasks.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Add sync and async clients both to tests. (#12)

* Add sync and async clients both to tests.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Minor fixes.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>

* Add dataSize option to java benchmark.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Jonathan Louie <[email protected]>
Co-authored-by: acarbonetto <[email protected]>
Co-authored-by: jonathanl-bq <[email protected]>
    @Yury-Fridlyand @jonathanl-bq @acarbonetto
    4 people committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    e57c1ff View commit details
    Browse the repository at this point in the history

  18. Rename jabushka to javababushka (#14) 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    8664d05 View commit details
    Browse the repository at this point in the history

  19. Add missing renames. (#17) 

    Signed-off-by: Yury-Fridlyand <[email protected]>
    @Yury-Fridlyand @acarbonetto
    Yury-Fridlyand authored and acarbonetto committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    b15f93e View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Add option to run tests on multiple clients in concurrency (#16) 

    * Add option to run tests on multiple clients in concurrency

* Common pool of iterations.
* Awaiting result from async methods.

Signed-off-by: Yury-Fridlyand <[email protected]>

* minor fix

Signed-off-by: Yury-Fridlyand <[email protected]>

* Change while-loop; Spotless Apply

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Co-authored-by: acarbonetto <[email protected]>
    @Yury-Fridlyand @acarbonetto
    Yury-Fridlyand and acarbonetto authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1bab56a View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Update redis-rs to match main branch 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    d99d27a View commit details
    Browse the repository at this point in the history

  2. Create clients only once per iteration (#19) 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    540f49a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Updated ClientCount to client_count for uniformity.

    @SanHalacogluImproving
    SanHalacogluImproving authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    65090b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Convert client count to snake case for rust benchmark. (#27) 

    * Updated ClientCount to client_count for uniformity for rust.
    @SanHalacogluImproving
    SanHalacogluImproving authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8a0449d View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Add json reporting. (#10) 

    * Add JSON reporting.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix for #26.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Update java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java

Signed-off-by: Yury-Fridlyand <[email protected]>

Co-authored-by: Andrew Carbonetto <[email protected]>

* Use `Optional`.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Address PR feedback.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
    @Yury-Fridlyand @acarbonetto
    Yury-Fridlyand and acarbonetto authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    c3d235a View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge remote-tracking branch 'upstream/main' into java_benchmarks 

    Signed-off-by: Yury-Fridlyand <[email protected]>
    @Yury-Fridlyand
    Yury-Fridlyand committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    fe9bb98 View commit details
    Browse the repository at this point in the history

  2. Typo fix. 

    Signed-off-by: Yury-Fridlyand <[email protected]>
    @Yury-Fridlyand
    Yury-Fridlyand committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    d533b7f View commit details
    Browse the repository at this point in the history

  3. Typo fix. 

    Signed-off-by: Yury-Fridlyand <[email protected]>
    @Yury-Fridlyand
    Yury-Fridlyand committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    9cbc9c2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'java_benchmarks' of github.com:Bit-Quill/babushka into … 

    …java_benchmarks

Signed-off-by: Yury-Fridlyand <[email protected]>
    @Yury-Fridlyand
    Yury-Fridlyand committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b00a205 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. fix java install_and_test script variables 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a62fe92 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into java_benchmarks

    @acarbonetto
    acarbonetto committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    30f2f62 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Java benchmarks clusters (#34) 

    * Add lettuce cluster client when cluster mode enabled

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
    @acarbonetto
    acarbonetto authored Nov 14, 2023
    Configuration menu
    Copy the full SHA
    05590b0 View commit details
    Browse the repository at this point in the history

  2. Clean up timer 

    Signed-off-by: acarbonetto <[email protected]>
    @acarbonetto
    acarbonetto committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bcf188c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Java client jni netty (#32) 

    * Add Java-client benchmarking app

Signed-off-by: acarbonetto <[email protected]>

* spotless apply

Signed-off-by: acarbonetto <[email protected]>

* Update on command line options

Signed-off-by: acarbonetto <[email protected]>

* Update README

Signed-off-by: acarbonetto <[email protected]>

* Spotless apply:

Signed-off-by: acarbonetto <[email protected]>

* Update README example

Signed-off-by: acarbonetto <[email protected]>

* update commandline defaults for review comments

Signed-off-by: acarbonetto <[email protected]>

* Remove TLS flag argument from option

Signed-off-by: acarbonetto <[email protected]>

* Add lettuce clients for benchmarking

Signed-off-by: acarbonetto <[email protected]>

* Spotless apply

Signed-off-by: acarbonetto <[email protected]>

* Add Jedis clients

Signed-off-by: acarbonetto <[email protected]>

* Add to app

Signed-off-by: acarbonetto <[email protected]>

* Add for-loop for data size list

Signed-off-by: acarbonetto <[email protected]>

* Add TPS for all async items

Signed-off-by: acarbonetto <[email protected]>

* spotless apply

Signed-off-by: acarbonetto <[email protected]>

* Fix TPS calculations

Signed-off-by: acarbonetto <[email protected]>

* Accept TLS as a flag

Signed-off-by: acarbonetto <[email protected]>

* Start threads; then wait for results

Signed-off-by: acarbonetto <[email protected]>

* Add java-jni client

Signed-off-by: acarbonetto <[email protected]>

* Handle Exceptions from client; add JniSyncClient fixes

Signed-off-by: acarbonetto <[email protected]>

* Clean up latency and add error checking

Signed-off-by: acarbonetto <[email protected]>

* Minor fixes.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix result printing.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Add TPS.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Remove duplicates. Reorganize and fix imports.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Int ctor fix.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Iteration 1.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Iteration 2: connected!

Signed-off-by: Yury-Fridlyand <[email protected]>

* Iteration 3: `get` and `set`.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Iteration 4: benchmark.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Iteration 5: some fixes.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Change number of threads in Benchmarking threadpool

* Revert "Change number of threads in Benchmarking threadpool"

This reverts commit e3f7596.

* Add more flushing rules and UT.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Client clean up.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Client optimizations. (#37)

* Client optimizations.

Signed-off-by: Yury-Fridlyand <[email protected]>

* minor cleanup.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Optimize building a command.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Typo fix.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Minor rename.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Clean up Redis close connection

Signed-off-by: Andrew Carbonetto <[email protected]>

* Clean up Redis close connection

Signed-off-by: Andrew Carbonetto <[email protected]>

* Minor changes.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Add todos to closeConnection()

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>

* Address PR feedback.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Rename

Signed-off-by: Yury-Fridlyand <[email protected]>

* Rename2

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix CI

Signed-off-by: Yury-Fridlyand <[email protected]>

* More fixes.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Some changes.

Signed-off-by: Yury-Fridlyand <[email protected]>

* add null check

Signed-off-by: Yury-Fridlyand <[email protected]>

* autoflush

Signed-off-by: Yury-Fridlyand <[email protected]>

* Apply suggestions from code review

Signed-off-by: Yury-Fridlyand <[email protected]>

Co-authored-by: Andrew Carbonetto <[email protected]>

* minor changes

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: acarbonetto <[email protected]>
Co-authored-by: Jonathan Louie <[email protected]>
    @Yury-Fridlyand @acarbonetto @jonathanl-bq
    3 people authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    b50d57e View commit details
    Browse the repository at this point in the history