Python: add ZRANGESTORE command #258
Conversation
Yury-Fridlyand
requested review from
GumpacG,
jonathanl-bq,
Yury-Fridlyand,
acarbonetto,
tjzhang-BQ and
jhmannok
| Stores a specified range of elements from the sorted set at `source`, into a new sorted set at `destination`. If | ||
| `destination` doesn't exist, a new sorted set is created; if it exists, it's overwritten. | ||
|
|
||
| When in Cluster mode, all keys must map to the same hash slot. |
There was a problem hiding this comment.
Should we add Note: ?
| When in Cluster mode, all keys must map to the same hash slot. | |
| When in Cluster mode, all `keys` must map to the same hash slot. |
There was a problem hiding this comment.
Not sure, I don't mind adding it but the existing docs do not have it and previous comments from Sho on other PRs suggest she prefers following existing doc patterns. Regarding angle quotes, I've noticed Sho has asked us to remove angle quotes on other PRs if they are not present in the existing docs, for example see:
valkey-io#1315 (comment)
valkey-io#1357 (comment)
Since keys is not surrounded by angle quotes in the existing docs and Sho seems to prefer following existing patterns I suggest we leave them without I don't mind adding them but I have a feeling she would ask me to remove them once this goes upstream
There was a problem hiding this comment.
We have it for 2 notes, but don't have it for one. Is it ok?
There was a problem hiding this comment.
Yeah not sure what the AWS preference would be. They don't have a Note: before the hash slot warning in the existing docs. But they also don't have any existing docs with both the hash slot warning and the notice about blocking commands.
There was a problem hiding this comment.
Following up, I followed the existing patterns (see here for details)
* Python: add ZRANGESTORE command (#258) * Update with PR link
* Python: add ZRANGESTORE command (#258) * Update with PR link
* Python: add ZRANGESTORE command (#258) * Update with PR link
No description provided.