Improved bitmap docs #344
Merged
Improved bitmap docs #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
292
to
293
| * specified <code>subCommands</code>. Can be routed to read-only replicas to allow for <code> | ||
| * BitField</code> behaviour in read-only replicas. |
There was a problem hiding this comment.
The phrase is correct and not at the same time.
We do not provide routing option for keyed commands. Should we add it here? Routing is determined automatically by GLIDE and user can do nothing there. A notice is correct, but useless.
There was a problem hiding this comment.
Should it just be allows for <code>BitField</code> behaviour in read-only replicas.?
There was a problem hiding this comment.
As discussed with @GilboaAWS, we need to copy it from valkey-io#1528
This command is routed depending on the the client's
ReadFromstrategy.
Yury-Fridlyand
approved these changes
Jun 5, 2024
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
…s.java Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
aaron-congo
pushed a commit
that referenced
this pull request
Jun 10, 2024
Improved bitmap docs (#344) * Improved bitmap docs * Addressed PR comments * Update java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java * Update java/client/src/main/java/glide/api/models/BaseTransaction.java --------- Co-authored-by: Yury-Fridlyand <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
Improved bitmap docs (#344) * Improved bitmap docs * Addressed PR comments * Update java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java * Update java/client/src/main/java/glide/api/models/BaseTransaction.java --------- Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.