Java: Add XACK stream command #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
* Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREADGROUP command Signed-off-by: Andrew Carbonetto <[email protected]> * Udpate IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Fix IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS & merge conflict fix Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/dev_acarbo_xack
branch
from
326f06b to
acdccf2
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand
approved these changes
Jun 20, 2024
GumpacG
reviewed
Jun 20, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
commented
Jun 20, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
GumpacG
approved these changes
Jun 20, 2024
| @SneakyThrows | ||
| @ParameterizedTest(autoCloseArguments = false) | ||
| @MethodSource("getClients") | ||
| public void xack_return_failures(BaseClient client) { |
There was a problem hiding this comment.
Should rename since it doesn't return all failures
There was a problem hiding this comment.
all the xack calls return failures?
aaron-congo
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Java: Add XACK stream command (#380) Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> Co-authored-by: Yi-Pin Chen <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Java: Add XACK stream command (#380) Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> Co-authored-by: Yi-Pin Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on XREADGROUP PR: valkey-io#1613
Adds the XACK command.