Merge pull request #4039 from BitGo/WIN-1012-move-methods-from-sdk-co…

…in-eth refactor(abstract-eth): move methods to abstract-eth
BitGo · Nov 11, 2023 · 5bc8c97 · 5bc8c97
2 parents af3a57b + af8bd10
commit 5bc8c97
Show file tree

Hide file tree

Showing 20 changed files with 2,808 additions and 2,947 deletions.
diff --git a/modules/abstract-eth/package.json b/modules/abstract-eth/package.json
@@ -40,13 +40,18 @@
     "@bitgo/sdk-core": "^8.26.0",
     "@bitgo/statics": "^29.0.0",
     "@bitgo/utxo-lib": "^9.16.0",
-    "bignumber.js": "^9.1.1",
-    "ethers": "^5.1.3",
-    "ethereumjs-util": "7.1.5",
     "@ethereumjs/common": "^2.6.5",
     "@ethereumjs/tx": "^3.3.0",
-    "ethereumjs-abi": "^0.6.5",
+    "bignumber.js": "^9.1.1",
     "bn.js": "^5.2.1",
-    "debug": "^3.1.0"
+    "debug": "^3.1.0",
+    "ethereumjs-abi": "^0.6.5",
+    "ethereumjs-util": "7.1.5",
+    "ethers": "^5.1.3",
+    "lodash": "4.17.21",
+    "keccak": "^3.0.3",
+    "secp256k1": "5.0.0",
+    "@bitgo/sdk-lib-mpc": "^8.15.0",
+    "@metamask/eth-sig-util": "^5.0.2"
   }
 }
diff --git a/modules/abstract-eth/src/abstractEthLikeCoin.ts b/modules/abstract-eth/src/abstractEthLikeCoin.ts
@@ -23,6 +23,7 @@ import {
 import BigNumber from 'bignumber.js';
 
 import { isValidEthAddress, KeyPair as EthKeyPair, TransactionBuilder } from './lib';
+import { VerifyEthAddressOptions } from './abstractEthLikeNewCoins';
 
 export interface EthSignTransactionOptions extends SignTransactionOptions {
   txPrebuild: TransactionPrebuild;
@@ -36,12 +37,12 @@ export interface TxInfo {
 }
 
 interface TransactionPrebuild extends BaseTransactionPrebuild {
-  txHex: string;
+  txHex?: string;
   txInfo: TxInfo;
   feeInfo: EthTransactionFee;
   source: string;
   dataToSign: string;
-  nextContractSequenceId?: string;
+  nextContractSequenceId?: number;
   expireTime?: number;
 }
 
@@ -134,7 +135,7 @@ export abstract class AbstractEthLikeCoin extends BaseCoin {
     return {};
   }
 
-  async isWalletAddress(): Promise<boolean> {
+  async isWalletAddress(params: VerifyEthAddressOptions): Promise<boolean> {
     throw new MethodNotImplementedError();
   }