feat(sdk-coin-islm): add Islamic Coin #3968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitansh-madan
force-pushed
the
WIN-490-add-haqq
branch
from
86ab885 to
990b287
Compare
| @@ -382,8 +382,8 @@ export class CosmosCoin extends BaseCoin { | |||
| const MESSAGE = Buffer.from(txHex, 'hex'); | |||
|
|
|||
| const [signA, signB] = [ | |||
| MPC.sign(MESSAGE, signCombineOne.oShare, signCombineTwo.dShare, createHash('sha256')), | |||
| MPC.sign(MESSAGE, signCombineTwo.oShare, signCombineOne.dShare, createHash('sha256')), | |||
| MPC.sign(MESSAGE, signCombineOne.oShare, signCombineTwo.dShare, this.getHashFunction()), | |||
There was a problem hiding this comment.
Please verify if OVC needs a change corresponding to this.
There was a problem hiding this comment.
I think it wouldn't, since this uses keccak256. And it seems in OVC we default to keccak256 unless explicitly added here
hitansh-madan
force-pushed
the
WIN-490-add-haqq
branch
2 times, most recently
from
16fddeb to
42ac53a
Compare
hitansh-madan
force-pushed
the
WIN-490-add-haqq
branch
from
42ac53a to
49f8ad9
Compare
hitansh-madan
force-pushed
the
WIN-490-add-haqq
branch
from
49f8ad9 to
456cb30
Compare
| @@ -0,0 +1,6 @@ | |||
| export const validDenoms = ['aISLM']; | |||
There was a problem hiding this comment.
There must be other denoms as well, like ISLMT as seen here -
https://testnet.ping.pub/haqq/tx/87C5D925D599D1E487523E1295566475BCDE7F94846A50B32413B4580497C6A3
Can you add all denoms.
nit: should be in lowercase.
There was a problem hiding this comment.
Oh, ISLMT is just how the explorer shows it, the denom in tx json still is aISLM. The denom is expected in this format on chain so lowercase wouldn't have worked.
hitansh-madan
force-pushed
the
WIN-490-add-haqq
branch
from
456cb30 to
c49bdd1
Compare
DinshawKothari
approved these changes
Oct 13, 2023
alebusse
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-490
ethsecp256k1) rather than cosmos defaultsecp256k1