Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(root): lock dot libs versions #3991

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

alebusse
Copy link
Contributor

@alebusse alebusse commented Oct 16, 2023

locked resolution of dot libs to enforce the right version on installation since they have minor changes with breaking changes

WP-837

TICKET: WP-837

@alebusse alebusse force-pushed the WP-837-fix-sdk-coin-dot-libs branch from 3369e0a to a4f7e1d Compare October 16, 2023 21:50
@socket-security
Copy link

socket-security bot commented Oct 16, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@alebusse alebusse force-pushed the WP-837-fix-sdk-coin-dot-libs branch 4 times, most recently from 1a99255 to 33a125c Compare October 16, 2023 22:35
@alebusse alebusse force-pushed the WP-837-fix-sdk-coin-dot-libs branch 3 times, most recently from 015a86f to f9250dc Compare October 24, 2023 19:03
fix sdk-coin-dot libs by locking their versions

WP-837

TICKET: WP-837
@alebusse alebusse force-pushed the WP-837-fix-sdk-coin-dot-libs branch from f9250dc to d31cb51 Compare October 24, 2023 19:06
@alebusse alebusse changed the title chore(root): lock @substrate/connect version for sdk-coin-dot chore(root): lock dot libs versions Oct 24, 2023
@alebusse alebusse marked this pull request as ready for review October 24, 2023 19:38
@alebusse alebusse requested review from a team as code owners October 24, 2023 19:38
@margueriteblair margueriteblair merged commit d4dbfd5 into master Oct 24, 2023
@alebusse alebusse deleted the WP-837-fix-sdk-coin-dot-libs branch October 24, 2023 19:54
@@ -62,6 +62,9 @@
"@types/keyv": "3.1.4",
"@types/react": "17.0.24",
"@types/react-dom": "17.0.16",
"@polkadot/api": "10.9.1",
"@polkadot/types": "10.9.1",
"@substrate/txwrapper-core": "7.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@substrate/txwrapper-substrate needs to be 7.0.1 as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to confirm that packages like @bitgo-beta/sdk-doin-dot when installed don't include the unintended versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants