Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename coin from 'core' to 'coreum' #4018

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

hitansh-madan
Copy link
Contributor

Ticket: WIN-1011

BREAKING CHANGE: rename coin module, coin name, named exports (etc.) for coreum

@hitansh-madan hitansh-madan force-pushed the WIN-1011-rename-coreum branch from a02e1fb to f72f86d Compare October 25, 2023 19:08
@hitansh-madan hitansh-madan marked this pull request as ready for review October 25, 2023 20:06
@hitansh-madan hitansh-madan requested review from a team as code owners October 25, 2023 20:06
@hitansh-madan hitansh-madan force-pushed the WIN-1011-rename-coreum branch from ffa39b6 to ee99bb1 Compare October 26, 2023 05:18
Ticket: WIN-1011

BREAKING CHANGE: rename coin module, coin name, named exports for coreum
@hitansh-madan hitansh-madan force-pushed the WIN-1011-rename-coreum branch from ee99bb1 to baecc01 Compare October 26, 2023 07:21
Copy link
Contributor

@OttoAllmendinger OttoAllmendinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sdk-core and sdk-coin-core was too close for comfort

@@ -64,7 +64,7 @@ COPY --from=builder /tmp/bitgo/modules/abstract-cosmos /var/modules/abstract-cos
COPY --from=builder /tmp/bitgo/modules/sdk-coin-bld /var/modules/sdk-coin-bld/
COPY --from=builder /tmp/bitgo/modules/sdk-coin-bsc /var/modules/sdk-coin-bsc/
COPY --from=builder /tmp/bitgo/modules/sdk-coin-celo /var/modules/sdk-coin-celo/
COPY --from=builder /tmp/bitgo/modules/sdk-coin-core /var/modules/sdk-coin-core/
COPY --from=builder /tmp/bitgo/modules/sdk-coin-coreum /var/modules/sdk-coin-coreum/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better

@hitansh-madan hitansh-madan merged commit 673590c into master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants