Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(abstract-eth): move methods to abstract-eth #4039

Merged
merged 1 commit into from
Nov 11, 2023
+2,808 −2,947
Merged

refactor(abstract-eth): move methods to abstract-eth #4039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions modules/abstract-eth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,18 @@
"@bitgo/sdk-core": "^8.26.0",
"@bitgo/statics": "^29.0.0",
"@bitgo/utxo-lib": "^9.16.0",
"bignumber.js": "^9.1.1",
"ethers": "^5.1.3",
"ethereumjs-util": "7.1.5",
"@ethereumjs/common": "^2.6.5",
"@ethereumjs/tx": "^3.3.0",
"ethereumjs-abi": "^0.6.5",
"bignumber.js": "^9.1.1",
"bn.js": "^5.2.1",
"debug": "^3.1.0"
"debug": "^3.1.0",
"ethereumjs-abi": "^0.6.5",
"ethereumjs-util": "7.1.5",
"ethers": "^5.1.3",
"lodash": "4.17.21",
"keccak": "^3.0.3",
"secp256k1": "5.0.0",
"@bitgo/sdk-lib-mpc": "^8.15.0",
"@metamask/eth-sig-util": "^5.0.2"
}
}
7 changes: 4 additions & 3 deletions modules/abstract-eth/src/abstractEthLikeCoin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
import BigNumber from 'bignumber.js';

import { isValidEthAddress, KeyPair as EthKeyPair, TransactionBuilder } from './lib';
import { VerifyEthAddressOptions } from './abstractEthLikeNewCoins';

export interface EthSignTransactionOptions extends SignTransactionOptions {
txPrebuild: TransactionPrebuild;
Expand All @@ -36,12 +37,12 @@ export interface TxInfo {
}

interface TransactionPrebuild extends BaseTransactionPrebuild {
txHex: string;
txHex?: string;
txInfo: TxInfo;
feeInfo: EthTransactionFee;
source: string;
dataToSign: string;
nextContractSequenceId?: string;
nextContractSequenceId?: number;
Copy link
Contributor Author

@gianchandania gianchandania Nov 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BREAKING CHANGE: Type of nextContractSequenceId is changed to number to avoid typescript error of incompatible function params for signTransaction method in AbstractEthLikeNewCoins and AbstractEthLikeCoin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have created a ticket WIN-1098 to address the change required in OVC because of this

expireTime?: number;
}

Expand Down Expand Up @@ -134,7 +135,7 @@ export abstract class AbstractEthLikeCoin extends BaseCoin {
return {};
}

async isWalletAddress(): Promise<boolean> {
async isWalletAddress(params: VerifyEthAddressOptions): Promise<boolean> {
throw new MethodNotImplementedError();
}

Expand Down
Loading
Loading