Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use whitelisted send params for tx initiate #4061

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: use whitelisted send params for tx initiate #4061

merged 1 commit into from
Nov 14, 2023

Conversation

bitgoAaron
Copy link
Contributor

  • limit params sent to the /tx/initiate API

Ticket: CE-3211

@bitgoAaron bitgoAaron requested review from a team as code owners November 13, 2023 19:29
@socket-security Socket Security
Copy link

socket-security bot commented Nov 13, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@bitgo/public-types 1.2.1 None +0 61.3 kB bitgobot

@bitgoAaron bitgoAaron force-pushed the aloe/usePubTypesInitiate branch from 971fe7a to ed9e9a3 Compare November 13, 2023 21:43
mohammadalfaiyazbitgo
mohammadalfaiyazbitgo previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bitgoAaron bitgoAaron force-pushed the aloe/usePubTypesInitiate branch 2 times, most recently from 6f7881a to e00a3a6 Compare November 14, 2023 00:32
rushilbg
rushilbg previously approved these changes Nov 14, 2023
View reviewed changes
rlutzbitgo
rlutzbitgo previously approved these changes Nov 14, 2023
View reviewed changes
@bitgoAaron
fix: use whitelisted send params for tx initiate
0cf9f4c 
- limit params sent to the /tx/initiate API

Ticket: CE-3211
@bitgoAaron bitgoAaron dismissed stale reviews from rlutzbitgo and rushilbg via 0cf9f4c November 14, 2023 17:27
@bitgoAaron bitgoAaron force-pushed the aloe/usePubTypesInitiate branch from e00a3a6 to 0cf9f4c Compare November 14, 2023 17:27
mkottaichamy
mkottaichamy approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@mkottaichamy mkottaichamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bitgoAaron bitgoAaron merged commit 3d2e692 into master Nov 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islamaminBitGo islamaminBitGo islamaminBitGo approved these changes

@rlutzbitgo rlutzbitgo rlutzbitgo approved these changes

@mkottaichamy mkottaichamy mkottaichamy approved these changes

@rushilbg rushilbg rushilbg left review comments

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo Awaiting requested review from mohammadalfaiyazbitgo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bitgoAaron @mkottaichamy @rlutzbitgo @mohammadalfaiyazbitgo @islamaminBitGo @rushilbg