feat(web-demo): add wasm miniscript to web demo #5340
Merged
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
force-pushed
the
BTC-1722.add-wasm-miniscript-to-web-demo
branch
from
237f32b to
bbd873e
Compare
OttoAllmendinger
changed the title
OttoAllmendinger
force-pushed
the
BTC-1722.add-wasm-miniscript-to-web-demo
branch
from
bbd873e to
a32ab73
Compare
OttoAllmendinger
commented
Jan 8, 2025
| @@ -88,6 +88,10 @@ const rules = [ | |||
| emitFile: false, | |||
| }, | |||
| }, | |||
| { | |||
| test: /miniscript.*\.wasm$/, | |||
| type: 'webassembly/sync', | |||
There was a problem hiding this comment.
For some reason webassembly/async does not work here. The import stays in some sort of deferred state.
OttoAllmendinger
force-pushed
the
BTC-1722.add-wasm-miniscript-to-web-demo
branch
from
a32ab73 to
0477848
Compare
davidkaplanbitgo
approved these changes
Jan 8, 2025
bitgoAaron
reviewed
Jan 8, 2025
| 'wpkh(xpub661MyMwAqRbcFQpwd6c6aaioiXWuygdeknqE8v6PSNusNjwZypj1uXTVNysfsFPEDL6X3yS1kL6JeWyy9bAiR97Gz8KD9Z1W54uBw9U9j2t/*)'; | ||
|
|
||
| export default function () { | ||
| const [descriptorString] = useState(defaultDescriptor); |
There was a problem hiding this comment.
NIT: you do not need useState for this
There was a problem hiding this comment.
I wanted to make this more interactive but didn't get around to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: BTC-1722