Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding missing config for coredao & oas to support non-bitgo recovery in WRW #5350

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: adding missing config for coredao & oas to support non-bitgo recovery in WRW #5350

merged 1 commit into from
Jan 9, 2025
+10 −0

Conversation

parasgarg-bitgo
Copy link
Contributor

Ticket: WIN-4290

@parasgarg-bitgo parasgarg-bitgo changed the title feat(sdk): adding support for non-bitgo recovery for coredao and oas feat: adding support for non-bitgo recovery for coredao and oas Jan 9, 2025
@parasgarg-bitgo parasgarg-bitgo marked this pull request as ready for review January 9, 2025 09:05
@parasgarg-bitgo parasgarg-bitgo requested review from a team as code owners January 9, 2025 09:05
margueriteblair
margueriteblair reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@margueriteblair margueriteblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR and the contents don't seem to have anything to do w/ each other? Can we change?

@parasgarg-bitgo parasgarg-bitgo changed the title feat: adding support for non-bitgo recovery for coredao and oas feat: adding missing config for coredao & oas to support non-bitgo recovery in WRW Jan 9, 2025
@parasgarg-bitgo
Copy link
Contributor Author

The title of the PR and the contents don't seem to have anything to do w/ each other? Can we change?

Updated the PR title

@parasgarg-bitgo parasgarg-bitgo merged commit 3b7df67 into master Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at31416 at31416 at31416 approved these changes

@veetragjain veetragjain veetragjain approved these changes

@pengyuc-bitgo pengyuc-bitgo pengyuc-bitgo approved these changes

@ayush-9 ayush-9 ayush-9 approved these changes

@margueriteblair margueriteblair Awaiting requested review from margueriteblair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@parasgarg-bitgo @ayush-9 @margueriteblair @pengyuc-bitgo @veetragjain @at31416