Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-sol): ignore zero value prio fee #5409

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Vijay-Jagannathan
Copy link
Contributor

Ticket: CR-1224

With this change, unless WP passes a prio fee > 0, we will not add a set compute price instruction. This is to ensure that we can dynamically change the prio fee value using an ENV variable in WP and if not, set the prio fee as 0

@Vijay-Jagannathan Vijay-Jagannathan force-pushed the ignore-zero-value-priority-fee branch from ade004a to a6cd5ee Compare January 22, 2025 05:57
Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vijay-Jagannathan Vijay-Jagannathan marked this pull request as ready for review January 22, 2025 06:55
@Vijay-Jagannathan Vijay-Jagannathan requested a review from a team as a code owner January 22, 2025 06:55
@Vijay-Jagannathan Vijay-Jagannathan merged commit 4f45498 into master Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants