feat: implement abstract substrate functions #5410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-bitgo
force-pushed
the
WIN-4299
branch
3 times, most recently
from
ab61c00 to
aa840e8
Compare
Comment on lines
+48
to
+53
| getAddress(format: DotAddressFormat): string { | ||
| let encodedAddress = this.createPolkadotPair().address; | ||
| encodedAddress = keyring.encodeAddress(encodedAddress, format as number); | ||
|
|
||
| return encodedAddress; | ||
| } |
There was a problem hiding this comment.
This shouldn't be implemented in this module itself since format could be a different number for different chains. This KeyPair class should be abstract and the coin can implement extend this class & this function depending on it's own network formats.
| throw new Error('missing txPrebuild parameter'); | ||
| } | ||
|
|
||
| if (!_.isString(txHex)) { |
There was a problem hiding this comment.
Avoid using lodash if possible
hitansh-madan
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implement abstract substrate class functions
TICKET: WIN-4299