refactor(apt): transaction builder #5428
Merged
+165
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baltiyal
force-pushed
the
COIN-2896-apt-transfer-correction
branch
from
da95911 to
21410fc
Compare
| @@ -50,4 +32,64 @@ export class TransferTransaction extends Transaction { | |||
| feePayer: this.feePayerAddress, | |||
| }; | |||
| } | |||
|
|
|||
| fromRawTransaction(rawTransaction: string): void { | |||
There was a problem hiding this comment.
This method will also stay in the parent class because it will be the same for all types of transactions.
| try { | ||
| const rawTxn = signedTxn.raw_txn; | ||
| this._sender = rawTxn.sender.toString(); | ||
| this._recipient = utils.getRecipientFromTransactionPayload(rawTxn.payload); |
There was a problem hiding this comment.
make getRecipientFromTransactionPayload an abstract method in the parent class, because only this portion varies for different transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: COIN-2896
Doesn't not need test cases, as already present test cases e.g.
apt.tsortransferBuilder.tsprovide sufficient coverage-Purpose-