Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(statics): add statics fields to common fields #5491

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

rakeshgsharma
Copy link
Contributor

@rakeshgsharma rakeshgsharma commented Feb 6, 2025

TICKET: WIN-4536

Description

We want to merge coin specific fields to common fields which are used across other coins. This ensures there's uniformity and eventually help building a proper structure for coin statics.

packageId::module::symbol -> contractAddress
tokenId-> contractAddress
contractName-> contractAddress
tokenAddress-> contractAddress
issuerAddress::currencyCode-> contractAddress

After we release this, we will be making necessary changes required in our systems to use the standard fields and then eventually remove these non-standard coin specific fields permanently.

Issue Number

WIN-4536

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This is non breaking change, and only adds extra fields which are already present.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rakeshgsharma rakeshgsharma requested review from a team as code owners February 6, 2025 13:38
@rakeshgsharma rakeshgsharma force-pushed the WIN-4536-add-statics-common-fields branch from ec5fdc9 to 77b86bb Compare February 6, 2025 13:52
@rakeshgsharma rakeshgsharma force-pushed the WIN-4536-add-statics-common-fields branch from 77b86bb to 0a54a69 Compare February 9, 2025 10:19
@rakeshgsharma rakeshgsharma force-pushed the WIN-4536-add-statics-common-fields branch from 0a54a69 to 0f3648e Compare February 9, 2025 10:23
@rakeshgsharma rakeshgsharma merged commit 19337c6 into master Feb 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants