Adding Staking Builder for Tao #5510
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijit0943
force-pushed
the
abhijit
branch
7 times, most recently
from
b4ed320 to
134d9a7
Compare
| should.deepEqual(txJson.tip, 0); | ||
| should.deepEqual(txJson.transactionVersion, 22); | ||
| should.deepEqual(txJson.chainName, 'Westend'); | ||
| should.deepEqual(txJson.eraPeriod, 64); |
There was a problem hiding this comment.
one interesting thing to check could be if it is able to re-build the transaction to the same transaction bytes - i think that this is something that happens during our internal transaction signing flow. could add something like this to the test:
const rawTx = tx.toBroadcastFormat();
const rebuilder = factory.from(rawTx);
rebuilder.sender({ ... }).validity({ ... }); // not sure if this part is needed
const rebuiltTx = await rebuilder.build();
assert(rebuiltTx.toBroadcastFormat() === rawTx);
noel-bitgo
reviewed
Feb 11, 2025
Comment on lines
+44
to
+53
| if (this._addToStake) { | ||
| tx = methods.staking.bondExtra({ maxAdditional: this._amount }, baseTxInfo.baseTxInfo, baseTxInfo.options); | ||
| } else { | ||
| tx = methods.staking.bond( | ||
| { controller: this._controller, value: this._amount, payee: this._payee }, | ||
| baseTxInfo.baseTxInfo, | ||
| baseTxInfo.options | ||
| ); | ||
| } | ||
| if (this._validityWindow && (tx as any).signature && baseTxInfo.options.registry) { |
There was a problem hiding this comment.
isn't this the DOT specific methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.