chore(eth-multisig-v4): add wemix config for contract deployment #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasgarg-bitgo
commented
Jan 24, 2025
| case 1112: | ||
| case 1111: | ||
| if ( | ||
| eip1559GasParams.maxPriorityFeePerGas?.lt( |
There was a problem hiding this comment.
For Wemix, we are not getting the correct gasFee for eip1559. As a workaround, we are updating the gasFee to be same as gasPrice.
parasgarg-bitgo
commented
Jan 24, 2025
|
|
||
| let batcher = null; | ||
| if (gasParams != undefined) { | ||
| batcher = await Batcher.deploy(transferGasLimit, gasParams); |
There was a problem hiding this comment.
Need to pass gasParams for wemix, as without the gasParams the contract deployment txn is underpriced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-4221
Deployed contracts locally on personal address:
https://testnet.wemixscan.com/address/0xbcb86416188235942990EA10c8D72e34170e7F18