Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epics autoreload for simplicity #1665

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Epics autoreload for simplicity #1665

wants to merge 2 commits into from

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Feb 9, 2024

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

Copy link

cypress bot commented Feb 9, 2024

Passing run #388 ↗︎

0 14 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 1425017 into 896b09c...
Project: NinjaWars Functional Testing Commit: 39c8b3c9d6 ℹ️
Status: Passed Duration: 02:02 💡
Started: Mar 29, 2024 2:14 PM Ended: Mar 29, 2024 2:16 PM

Review all test suite changes for PR #1665 ↗︎

@tchalvak tchalvak added the hold label Feb 9, 2024
@tchalvak tchalvak marked this pull request as draft February 9, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant