Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dissect: add module packages #4361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dissect: add module packages #4361

wants to merge 1 commit into from

Conversation

D3vil0p3r
Copy link
Contributor

Close #3688

@D3vil0p3r D3vil0p3r marked this pull request as ready for review November 18, 2024 15:14
@D3vil0p3r D3vil0p3r mentioned this pull request Nov 18, 2024
Open
noraj
noraj requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of work. I don't have time to test this right now. At a glance I can see license identifiers are old, could you upgrade to SPDX identifier please?

I hope in the long run that won't turn to be a hell to maintain and that we won't need to switch to virtualenv.

@D3vil0p3r
Copy link
Contributor Author

Licenses upgraded. I did basic tests on all of them during packaging and they worked correctly.

@D3vil0p3r D3vil0p3r requested a review from noraj November 19, 2024 19:51
@noraj
Copy link
Contributor

noraj commented Nov 19, 2024

Licenses upgraded. I did basic tests on all of them during packaging and they worked correctly.

Yes but it will be soon obsolete when AL RFC-0016 will be finalised.

https://wiki.archlinux.org/title/PKGBUILD#license

Note: Arch Linux is currently undergoing a transition to SPDX style identifiers. Some issues may still require ironing out. This section focuses on the SPDX format. If you encounter any trouble, please report them and discuss with the community.

@D3vil0p3r
Copy link
Contributor Author

At least we can manage that massive license change by 1 or 2 sed commands. Btw thanks for the last link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noptrix noptrix Awaiting requested review from noptrix noptrix is a code owner

@noraj noraj Awaiting requested review from noraj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dissect
2 participants
@D3vil0p3r @noraj