fix(web): remove navigation items component loading skeleton #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15bf32e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 88.81% 88.80% -0.01%
==========================================
Files 163 163
Lines 11094 11090 -4
Branches 1208 1208
==========================================
- Hits 9853 9849 -4
Misses 1241 1241 ☔ View full report in Codecov by Sentry. |
Merged
luis-herasme
pushed a commit
that referenced
this pull request
Feb 24, 2025
* chore(web): parse `PUBLIC_SUPPORTED_NETWORKS` env var * fix(web): prevent skeleton display in navigation items component regardless of env var loading * chore: add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
It fixes an issue where the navigation menus component was displaying a loading skeleton while the env vars were being fetched
Now it displays the component regardless of env var loading
It also adds zod logic to parse
PUBLIC_SUPPORTED_NETWORKSenv var instead of handling it on the clientMotivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
Screen.Recording.2025-02-14.at.19.05.34.mov