Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation and testing of config/cli.go #18

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

ABD-AZE
Copy link

@ABD-AZE ABD-AZE commented Aug 25, 2024

Resolves #15

  1. Building and testing done successfully
  2. CliConfig Struct defined
  3. as_provider() function serializes the struct to map[string]{interface}
  4. written test for as_provider() function using viper for testing but any other config management lib can be used for the project as the testing was only for checking the serialization process.

@star-gazer111
Copy link
Member

@ABD-AZE We are using Viper for now right?

@star-gazer111
Copy link
Member

LGTM

@ABD-AZE
Copy link
Author

ABD-AZE commented Aug 25, 2024

I have used viper just for testing that the data is getting serialised. It is not necessary to use viper for the whole project.

config/cli.go Outdated
type CliConfig struct {
ExecutionRPC *string `mapstructure:"execution_rpc"`
Copy link
Contributor

@gerceboss gerceboss Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ABD-AZE ,Change ExecutionRPC to ExecutionRpc, similarly do for RPC and IP everywhere

@ABD-AZE ABD-AZE requested a review from gerceboss August 26, 2024 14:13
@star-gazer111 star-gazer111 merged commit 6260908 into BlocSoc-iitr:dev Aug 26, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants