Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement consenus test go #69

Merged
merged 12 commits into from
Oct 15, 2024

Conversation

DarkLord017
Copy link

No description provided.

@DarkLord017
Copy link
Author

  1. Consensus test case passed
  2. Made consensus core work by adding json tags
  3. Made serde_utils to handle deserialisation of structs that are required
  4. Some structs are left and also it is improper as importing from utils causes import cycle error

@DarkLord017 DarkLord017 marked this pull request as ready for review October 7, 2024 22:03
@DarkLord017
Copy link
Author

@star-gazer111

@star-gazer111
Copy link
Member

4. Some structs are left and also it is improper as importing from utils causes import cycle error

which one exactly?

@DarkLord017
Copy link
Author

Seeing serde_utils.go I implemented all the structs that were required to complete the test cases

Since there was an import cycle issue so I for sake of making the tests work I copied the functions into serde_utils.go

Structs related to deserialisation of beacon block body are just left

@DarkLord017
Copy link
Author

Check @star-gazer111

@star-gazer111 star-gazer111 merged commit 8c4553f into BlocSoc-iitr:dev Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants