Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck consensus test #72

Merged
merged 15 commits into from
Nov 4, 2024

Conversation

DarkLord017
Copy link

No description provided.

@DarkLord017 DarkLord017 marked this pull request as ready for review October 15, 2024 17:33
@DarkLord017
Copy link
Author

check @star-gazer111

@BlocSoc-iitr BlocSoc-iitr deleted a comment from DarkLord017 Oct 15, 2024
@gerceboss
Copy link
Contributor

@DarkLord017 , please donot add the test files and changes in other files according to them in one PR, better to keep PR for tests distinct.
Either you can split this PR into 2 and the changes you made to other ones in a different PR

@star-gazer111
Copy link
Member

better to keep PR for tests distinct.

Good point. This should be taken care of in every PR. @DarkLord017

@star-gazer111
Copy link
Member

Either you can split this PR into 2

No need to do it for now I suppose, I have already reviewed this PR for now

@star-gazer111 star-gazer111 merged commit 3a779b2 into BlocSoc-iitr:dev Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants