Update TimeLock.sol #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| function increaseLockTime(uint256 newLockTime) external { | ||
| require(newLockTime > balances[msg.sender].lockTime, "New lock time must be greater"); | ||
| balances[msg.sender].lockTime = newLockTime; |
There was a problem hiding this comment.
Increase lock time instead of setting it directly.
for Example.
if u pass 5 as input
it should lock the deposited amount for 5 min from the time , increaseLockTime() function has been called, if calculated time is more than the last locktime then change else don't.
| return balances[msg.sender]; | ||
| } | ||
|
|
||
| function getOwnerCount() public view returns (uint256) { |
There was a problem hiding this comment.
getOwnerCount() is not working
Try using an array instead of a map to store owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3 done