Skip to content

Commit

Permalink
signer: Relax two rules to be warnings only
Browse files Browse the repository at this point in the history
We need to accept repeat signature requests and revocations for older
states because the signer state update and the CLN state update are
not atomic, i.e., the signer commits first, therefore ratchets up,
before CLN stores its state, meaning we could potentially replay some
prior state due to a preemption and restart inbetween. Relaxing these
two should address the majority of our desync issue.
  • Loading branch information
cdecker committed Oct 9, 2024
1 parent 70bd1ab commit a11761e
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions libs/gl-client/src/signer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ impl Signer {
rules: vec![
FilterRule::new_warn("policy-channel-safe-type-anchors"),
FilterRule::new_warn("policy-routing-balanced"),
FilterRule::new_warn("policy-commitment-retry-same"),
],
});

Expand All @@ -141,6 +142,16 @@ impl Signer {
],
});

// TODO: Remove once we found the desync issue
policy.filter.merge(PolicyFilter {
rules: vec![
// "policy failure: get_per_commitment_secret: cannot
// revoke commitment_number 312 when
// next_holder_commit_num is 313"
FilterRule::new_warn("policy-revoke-new-commitment-signed"),
],
});

// Increase the invoices limit. Results in a larger state, but
// bumping into this is rather annoying.
policy.max_invoices = 10_000usize;
Expand Down

0 comments on commit a11761e

Please sign in to comment.