Merge pull request #55 from BloodHoundAD/fix-bhe-client-transport

fix: close request body after computing hash
BloodHoundAD · Oct 12, 2023 · a4a6de5 · a4a6de5
2 parents ed2e55e + 8260b84
commit a4a6de5
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/cmd/utils.go b/cmd/utils.go
@@ -290,6 +290,10 @@ func (s *rewindableByteReader) Rewind() (int64, error) {
 	return s.data.Seek(0, io.SeekStart)
 }
 
+func discard(reader io.Reader) {
+	io.Copy(io.Discard, reader)
+}
+
 type signingTransport struct {
 	base      http.RoundTripper
 	tokenId   string
@@ -332,6 +336,10 @@ func (s signingTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 				tee     = io.TeeReader(req.Body, body)
 			)
 
+			defer req.Body.Close()
+			defer discard(tee)
+			defer discard(body)
+
 			for {
 				numRead, err := tee.Read(hashBuf)
 				if numRead > 0 {