Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diesel tool sounds - First Draft / Feedback desired #5955

Open
wants to merge 21 commits into
base: 1.21.1
Choose a base branch
from
Open

Diesel tool sounds - First Draft / Feedback desired #5955

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
5ab2f23
Initial commit
Jun 17, 2024
60ec43b
first presentable draft
Jun 17, 2024
8e4c57a
pulled out tool sounds from DieselToolItem into INoisyTool interface
Jun 19, 2024
18f42f3
made get<*>Sound calls take ItemStack as argument
Jun 20, 2024
bec5a6c
added a temporary static for volume adjustment in INoisyTool
Jun 20, 2024
f49008e
added a fading sound to the tools to make digging quickly mined block…
Jun 20, 2024
2577012
fixed single-stutter bug when beginning to harvest
Jun 21, 2024
8356a3d
added important remarks to the INoisyTool
Jun 21, 2024
b596051
fixed follow-up stutter bug from fixing the first stutter bug 🤡
Jun 21, 2024
7e2ce26
correct checkItemMatch to compare stacks not items, since sounds are …
Jun 22, 2024
7788264
fix edge case NPE
Jun 22, 2024
60cff43
replace placeholder saw blade sound
Jun 22, 2024
310af64
rebalance buzzsaw grinding sound volume to be more in line with the o…
Jun 22, 2024
d0bae35
fixed checkItemMatch failing because updating any values on a tool it…
Jun 22, 2024
12506d9
made the same-stack check item based instead of static
Jun 22, 2024
ddeff4c
clear sound groups on leaving level (change level or back to menu)
Jun 22, 2024
a54230d
post rebase cleanup/bugfix and update to 1.21
Dec 8, 2024
eed9dd3
added missing generated resource lang file(?)
Dec 9, 2024
3fa7ce7
fixed wrong symbol(?) I don't even wanna know how that came into being
Dec 9, 2024
e20730b
added missing datagen-ed .cache file
Dec 9, 2024
3c35256
Rerun datagen
malte0811 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rerun datagen
  • Loading branch information
@malte0811
malte0811 committed Dec 12, 2024
commit 3c35256a853cb50a25d121fc864b6b330072a694
4 changes: 2 additions & 2 deletions src/generated/resources/.cache/b42e1ae3eb4defee251f4fded9b88ae0c946b758
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading