Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable compression for outgoing requests #4279

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Enable compression for outgoing requests #4279

merged 4 commits into from
Sep 19, 2023

Conversation

imsdu
Copy link
Contributor

@imsdu imsdu commented Sep 18, 2023 •
edited
Loading

Fixes #4249

I reused the compression flag instead of introducing a new one as:

  • It was always enabled
  • The Accept-Encoding header was correctly set to gzip and deflate

Allows to enable compression for outgoing requests:

  • Only enabled for Elasticsearch by default (Blazegraph does not support it and there is an error with Keycloak where the payloads are always minimal anyway)

olivergrabinski
olivergrabinski suggested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@olivergrabinski olivergrabinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this warrant a note in the release notes?

@imsdu imsdu merged commit 46d110a into BlueBrain:master Sep 19, 2023
6 checks passed
@imsdu imsdu deleted the 4249-enable-compression-outgoing-requests branch September 19, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivergrabinski olivergrabinski olivergrabinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to compress payloads from outgoing requests from the Http client
2 participants
@imsdu @olivergrabinski