Storage permission endpoint #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyhappydan
commented
Sep 29, 2023
...orage/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/StoragePluginModule.scala
Outdated
Show resolved
Hide resolved
delta/sdk/src/main/scala/ch/epfl/bluebrain/nexus/delta/sdk/directives/AuthDirectives.scala
Outdated
Show resolved
Hide resolved
shinyhappydan
commented
Sep 29, 2023
...src/main/scala/ch/epfl/bluebrain/nexus/delta/sdk/permissions/StoragePermissionProvider.scala
Show resolved
Hide resolved
...orage/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/StoragePluginModule.scala
Show resolved
Hide resolved
dantb
approved these changes
Sep 30, 2023
| import ch.epfl.bluebrain.nexus.delta.sourcing.model.ProjectRef | ||
| import monix.bio.UIO | ||
|
|
||
| class StoragePermissionProviderImpl(storages: Storages) extends StoragePermissionProvider { |
There was a problem hiding this comment.
Appreciate this is just following the existing pattern but was wondering about the XxxImpl thing all over the codebase - are there any downsides to sticking them in the companion objects and having anonymous instances? I understand the separation was an old pattern but they always seem to be in the same module anyway so it sort of just adds bloat to the codebase with no upside AFAICT (new file, all the imports again, new-ing things up etc)
There was a problem hiding this comment.
The main issue here is that the implementation needs to be in a different module to the trait. Usually I would have written it in the way you describe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4264