Migrate archives to Cats Effect #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2023 19:29
imsdu
commented
Oct 10, 2023
| * @param subject | ||
| * the subject that initiated the action | ||
| */ | ||
| def create( |
imsdu
commented
Oct 10, 2023
| * Apache License 2.0): | ||
| * https://github.com/krasserm/streamz/blob/master/streamz-converter/src/main/scala/streamz/converter/Converter.scala | ||
| */ | ||
| object CatsStreamConverter { |
There was a problem hiding this comment.
Yet another copy of a class existing for Monix for Cats Effects.
There was a problem hiding this comment.
Why not migrate it? Seems like it would have only a small impact outside of archives?
There was a problem hiding this comment.
It is used by SSEs and composite views too for the moment
olivergrabinski
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4328