Fix error when creating a view with invalid mappings or settings #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsdu
commented
Oct 12, 2023
| @@ -20,8 +18,6 @@ plugins.elasticsearch { | |||
| prefix = ${app.defaults.indexing.prefix} | |||
| # configuration of the maximum number of view references allowed on an aggregated view | |||
| max-view-refs = 20 | |||
| # the maximum idle duration in between events on the indexing stream after which the stream will be stopped (min. 10 minutes). | |||
| idle-timeout = 30 minutes | |||
imsdu
commented
Oct 12, 2023
| @@ -53,8 +53,8 @@ class ElasticSearchPluginModule(priority: Int) extends ModuleDef { | |||
| make[ElasticSearchViewsConfig].from { ElasticSearchViewsConfig.load(_) } | |||
|
|
|||
| make[HttpClient].named("elasticsearch-client").from { | |||
| (cfg: ElasticSearchViewsConfig, as: ActorSystem[Nothing], sc: Scheduler) => | |||
| HttpClient()(cfg.client, as.classicSystem, sc) | |||
| val httpConfig = HttpClientConfig.noRetry(true) | |||
There was a problem hiding this comment.
The retry strategy was responsible for timeouts.
We don't need retries when interacting with Elasticsearch so it is better to let things fail when it returns an error
olivergrabinski
previously approved these changes
Oct 13, 2023
| val invalidMapping = | ||
| json"""{"mapping": "fail"}""" | ||
| val payload = json"""{ "@type": "ElasticSearchView", "mapping": $invalidMapping }""" | ||
| deltaClient.put[Json](s"/views/$fullId/invalid", payload, ScoobyDoo) { expectBadRequest } |
There was a problem hiding this comment.
The invalid segment reads as if the view id is invalid, when the issue is the payload. The payload could be called payloadWithInvalidMapping, and the view id something else than invalid. Similar comment on the other test
tests/src/test/scala/ch/epfl/bluebrain/nexus/tests/kg/ElasticSearchViewsSpec.scala
Outdated
Show resolved
Hide resolved
olivergrabinski
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4313