Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SSE to cats effect #4367

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Migrate SSE to cats effect #4367

merged 2 commits into from
Oct 16, 2023

Conversation

shinyhappydan
Copy link
Contributor

@shinyhappydan shinyhappydan commented Oct 16, 2023 •
edited
Loading

Fixes #4331

olivergrabinski
olivergrabinski previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@olivergrabinski olivergrabinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • One thing that could be done is not to use the cats.IO => CIO alias. Instead rename the monix.IO => BIO as we did so far. Then we only have to delete things, and not rename things again. But it's easy enough to do and can be done later I guess.
  • There's at least one place where EitherT could be used without much impact, which I think makes the code easier to read. But it's not critical

@shinyhappydan shinyhappydan merged commit 5c3ec3d into BlueBrain:master Oct 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivergrabinski olivergrabinski olivergrabinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Sse module to CE
2 participants
@shinyhappydan @olivergrabinski