Add endpoint to show source of resolved resources #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyhappydan
commented
Nov 7, 2023
There was a problem hiding this comment.
All the changes here are just renames
delta/app/src/main/scala/ch/epfl/bluebrain/nexus/delta/routes/ResolversRoutes.scala
Outdated
Show resolved
Hide resolved
shinyhappydan
requested review from
imsdu,
olivergrabinski and
dantb
and removed request for
olivergrabinski
dantb
previously approved these changes
Nov 7, 2023
delta/app/src/main/scala/ch/epfl/bluebrain/nexus/delta/routes/ResolversRoutes.scala
Outdated
Show resolved
Hide resolved
|
The endpoint need to be documented otherwise it looks good to me |
shinyhappydan
force-pushed
the
resolved-resource-source
branch
from
8c4c0ca to
d5c379d
Compare
dantb
suggested changes
Nov 7, 2023
Comment on lines
200
to
202
| case ResolvedResourceOutputType.Report => emit(io.map(_.report).attemptNarrow[ResolverRejection]) | ||
| case ResolvedResourceOutputType.JsonLd => emit(io.map(_.value.source).attemptNarrow[ResolverRejection]) | ||
| case ResolvedResourceOutputType.Source => emit(io.map(_.value.jsonLdValue).attemptNarrow[ResolverRejection]) |
There was a problem hiding this comment.
Much clearer 🙌 but I think the last two are the wrong way round
dantb
previously approved these changes
Nov 7, 2023
dantb
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4462