Remove scalalogging library #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsdu
commented
Nov 10, 2023
| @@ -115,7 +114,7 @@ lazy val munit = "org.scalameta" %% "munit" | |||
| lazy val nimbusJoseJwt = "com.nimbusds" % "nimbus-jose-jwt" % nimbusJoseJwtVersion | |||
| lazy val pureconfig = "com.github.pureconfig" %% "pureconfig" % pureconfigVersion | |||
| lazy val pureconfigCats = "com.github.pureconfig" %% "pureconfig-cats" % pureconfigVersion | |||
| lazy val scalaLogging = "com.typesafe.scala-logging" %% "scala-logging" % scalaLoggingVersion | |||
| lazy val scalaReflect = "org.scala-lang" % "scala-reflect" % scalaCompilerVersion | |||
There was a problem hiding this comment.
I had to introduce this one as it was a transitive dependency from scalalogging that is needed for Magnolia
added 2 commits
November 10, 2023 10:40
olivergrabinski
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.