Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject ambiguous organization DELETE requests #4503

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Reject ambiguous organization DELETE requests #4503

merged 6 commits into from
Nov 16, 2023

Conversation

dantb
Copy link
Contributor

@dantb dantb commented Nov 16, 2023

Fixes #4502

olivergrabinski
olivergrabinski previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@olivergrabinski olivergrabinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note the example for org deletion in the doc is wrong since it has just the rev query parameter but not prune=true

@olivergrabinski olivergrabinski merged commit 693db72 into BlueBrain:master Nov 16, 2023
6 checks passed
@dantb dantb deleted the fix-ambiguous-org-deletion branch November 16, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivergrabinski olivergrabinski olivergrabinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using query parameters prune=true&rev={rev} should not deprecate an org
2 participants
@dantb @olivergrabinski