Remove the ability to tag storages #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantb
force-pushed
the
remove-storages-tagging
branch
2 times, most recently
from
e8a5346 to
61eb2dd
Compare
imsdu
requested changes
Jan 18, 2024
.../src/test/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/storages/StoragesStmSpec.scala
Show resolved
Hide resolved
.../src/test/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/storages/StoragesStmSpec.scala
Show resolved
Hide resolved
imsdu
requested changes
Jan 18, 2024
...storage/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/storages/Storages.scala
Show resolved
Hide resolved
...storage/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/storages/Storages.scala
Show resolved
Hide resolved
imsdu
reviewed
Jan 18, 2024
...ain/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/storages/routes/StoragesRoutes.scala
Show resolved
Hide resolved
imsdu
reviewed
Jan 19, 2024
| @@ -368,10 +335,6 @@ object Storages { | |||
| s.copy(rev = e.rev, value = e.value, source = e.source, updatedAt = e.instant, updatedBy = e.subject) | |||
| } | |||
|
|
|||
| def tagAdded(e: StorageTagAdded): Option[StorageState] = state.map { s => | |||
There was a problem hiding this comment.
I think we still need to compute a new state and update the rev, we may break some history otherwise.
For example, this should still work:
- StorageCreated
- StorageTagged
- StorageUpdated
We should still have a storage with revision 3
dantb
force-pushed
the
remove-storages-tagging
branch
from
ba47407 to
42e79be
Compare
imsdu
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4652