Use localstack for S3 integration tests #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantb
changed the title
imsdu
reviewed
Mar 7, 2024
...brain/nexus/delta/plugins/storage/storages/operations/s3/S3StorageAccessSpecLocalStack.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Mar 7, 2024
| private val logoKey = "some/path/to/nexus-logo.png" | ||
|
|
||
| val s3Endpoint: String = s"http://delta.bbp:9000" | ||
| val s3BucketEndpoint: String = s"http://$bucket.delta.bbp:9000" | ||
| val s3Endpoint: String = "http://s3.localhost.localstack.cloud:4566" |
There was a problem hiding this comment.
Can the suffix be configured ?
There was a problem hiding this comment.
localstack.cloud
It is just a detail though
imsdu
reviewed
Mar 7, 2024
tests/src/test/scala/ch/epfl/bluebrain/nexus/tests/kg/files/S3StorageSpec.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Mar 7, 2024
imsdu
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I commented out some tests using testcontainers-scala with localstack. They'll be useful when we ditch Minio completely
FYI you can also run localstack separately with
then hit it with
awslocal(wrapper around theawsCLI) or use the desktop application to browse AWS resources