Do not validate schemas when importing with nexus ship #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsdu
reviewed
Apr 3, 2024
| @@ -50,6 +50,9 @@ class SchemaProcessor private (schemas: Schemas, projectMapper: ProjectMapper, c | |||
| { | |||
| case a: ResourceAlreadyExists => logger.warn(a)("The schema already exists").as(ImportStatus.Dropped) | |||
| case i: IncorrectRev => logger.warn(i)("An incorrect revision has been provided").as(ImportStatus.Dropped) | |||
| case i: InvalidSchema => | |||
There was a problem hiding this comment.
We don't need this as it won't happen if there is no validation
imsdu
approved these changes
Apr 3, 2024
olivergrabinski
commented
Apr 3, 2024
Comment on lines
+53
to
+55
| case i: InvalidSchema => | ||
| val message = s"The schema '${i.id}' is invalid. Report: ${i.report}" | ||
| logger.error(message) >> IO.raiseError(i) |
There was a problem hiding this comment.
Without validation this technically should not occur anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to pre-1.5 schemas failing to validate while importing, we disable the validation in the ship.